Hashing the password with pre saving middleware

Working with Data Node.js Frameworks
1

i have this line of code,i just want to know if it’s good practice to hash the password with the pre-save middleware like code below.? i mean is there is a securty issue about this or put something in the .env file

 UserSchema.pre("save", async function (next) {
  try {
    const hashedhPassword = await bcrypt.hash(this.password, 10);
    this.password = hashedhPassword;
  } catch (err: any) {
    next(err);
  }
});
2

This looks simple and clean . You don’t need to pull your salt to env . I would prefer pulling salt from a secret store while bootstrapping application .

3

yeh not the bad approach to hashing the password in pre save just implement some check in the schema and don’t make it too simple for hashing