Hashing the password with pre saving middleware

Ari_Raouf · 2024-07-16T17:20:08.407Z

i have this line of code,i just want to know if it’s good practice to hash the password with the pre-save middleware like code below.? i mean is there is a securty issue about this or put something in the .env file

 UserSchema.pre("save", async function (next) {
  try {
    const hashedhPassword = await bcrypt.hash(this.password, 10);
    this.password = hashedhPassword;
  } catch (err: any) {
    next(err);
  }
});

Vivekanandan_Sakthivelu · 2024-07-18T09:39:45.320Z

This looks simple and clean . You don’t need to pull your salt to env . I would prefer pulling salt from a secret store while bootstrapping application .

Aniket_Ghavte · 2024-12-28T13:28:46.660Z

yeh not the bad approach to hashing the password in pre save just implement some check in the schema and don’t make it too simple for hashing